Make cqlsh work with unix domain sockets #67
Conversation
|
Lgtm But I think we need to wait for To be merged and released And then update that cqlsh is dependent on that (and update the requirements.txt, cause this what would be packged by scylla core) |
@fruch @avelanarius that fix was merged -- will we get a driver release soon? (Sorry for asking for so many driver releases recently... I hope it's not too much of a PITA) |
|
@kbr-scylla @Lorak-mmk will release today. |
|
Nice, thanks. |
|
@sylwiaszunejko Python Driver is now released, you can bump the version in Line 1 in 8bd3367 |
In order to use WhiteListRoundRobinPolicy we have to wrap hostname in UnixSocketEndPoint. This commit adds checking if hostname is a socket, and if so, it adds wrapping hostname into UnixSocketEndPoint.
sylwiaszunejko
force-pushed
the
add_unix_socket_handling
branch
from
601226e to
2865af0
Compare
|
I updated the python-driver version in requirements.txt. |
|
Now we need to update the cqlsh submodule in scylla core to take this change |
Queued scylladb/scylladb@cc03949 Do we have some test suite for cqlsh? It would be good to have a regression test |
It has its own tests/CI, and quite good coverage in dtest gating (not the newly introduced feature, but that should be easy to add) |
After scylladb/scylla-cqlsh#67, the user can use cqlsh to connect to the node by maintenance socket.
After scylladb/scylla-cqlsh#67, the user can use cqlsh to connect to the node by maintenance socket.
In order to use unix domain sockets with python-driver, we have to wrap hostname in UnixSocketEndPoint (like in this example: http://opensource.docs.scylladb.com/master/operating-scylla/admin-tools/maintenance-socket.html#with-python-driver).
This PR adds checking if hostname is a socket, and if so, it adds wrapping hostname into UnixSocketEndPoint.
I tested it locally using python-driver.
To work correctly it needs 3.26.5 python-driver release (there was no support for unix domain sockets in
WhiteListRoundRobinPolicybefore).Fixes: scylladb/scylladb#16489